stillwater-sc / universal / 31844197988
85%
master: 84%

LAST BUILD BRANCH: main
DEFAULT BRANCH: master
Ran
Jobs 1
Files 616
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 85.414% (-0.01%) from 85.428%
31844197988

push

github

web-flow 
test(takum_log): cover multiply and divide rounding at 64 bits (#1313)

The correctly-rounded reference check ran at 8 and 10 bits only, so the width
this arithmetic exists for had no committed coverage.  #1312 verified it against
a 113-bit __float128 oracle, but that needs quadmath and cannot ship, which left
the headline claim -- 99.22% incorrectly rounded to 0.00% at takum_log<64,3> --
resting on nothing in the tree.

Two things had to change to add it.

VerifyCorrectlyRounded bounded its sweep with 1ull << nbits, which is undefined
at nbits == 64.  It was dormant, since nothing instantiated it there, but it is
precisely what stopped the 64-bit case being a one-line addition.  The bound is
now expressed without a 64-bit shift, and the same latent trap is removed from
VerifyIdentities and VerifyCommutative, which are only instantiated narrow today
but had the same construction.

The sweep is over PAIRS, so it needed a stride rather than enumeration.  A first
attempt used one giving ~12,000 samples per operand, which is 151 million pairs
each doing several dd_cascade operations; it did not finish.  At ~225 samples per
operand the whole suite runs in 3.4 seconds.

Confirmed to discriminate: removing the division borrow trips the 64-bit case
with 24,288 failures while correctly leaving multiplication passing, since that
path does not borrow.

42249 of 49464 relevant lines covered (85.41%)

7263790.1 hits per line

Coverage Regressions

Lines Coverage ∆ File
8
93.73
 -0.47% include/sw/universal/number/cfloat/cfloat_impl.hpp
Jobs
ID Job ID Ran Files Coverage
1 31844197988.1 616
85.41
 GitHub Action Run
Source Files on build 31844197988