decentraland / asset-bundle-registry / 31841065984

74%

main: 73%

Pull #131

github

feat: serve default profiles from the catalyst fallback

A default profile pointer that missed the cache and the database resolved to
nothing, so `/profiles` answered for an address but not for a name it accepts.

Lambdas reports every default profile under the same deployer address, so a batch
answer cannot be attributed to the names that were asked for. Each name is
therefore asked for on its own, where the single answer is unambiguously the one
requested, and is keyed and stored under that name. That is what tells us which
question was answered, not a check on the answer itself.

`convertLambdasProfileToEntity` takes the pointer to key the entity by, since a
name cannot be derived from the answer, and settles the identity only when that
pointer is an address: a default profile keeps the deployer address it carries,
matching what ingestion and the stored rows do.

Name lookups run in bounded chunks and the request schema caps how many may be
asked for at once, since each one costs a request. Addresses stay uncapped and
resolve in a single batch as before.

Before this, the fallback did answer for a default name, but keyed the entity by
the deployer address it reported, so the row landed on that account instead and
shadowed its profile. That is fixed by keying on the requested name.

686 of 976 branches covered (70.29%)

Branch coverage included in aggregate %.

49 of 51 new or added lines in 4 files covered. (96.08%)

1783 of 2383 relevant lines covered (74.82%)

42.39 hits per line