pmd / pmd / 726

79%

Build Type

push

github

Committed by web-flow

Commit Message

[core] Fix #6913: Use the configured class loader in RuleSetLoader#loadFromString (#6921)

loadFromString wrapped the configured ResourceLoader in an anonymous
subclass created with the no-arg constructor, so the wrapper fell back
to PMD's own class loader. Resource lookups still worked because
loadResourceAsStream delegates to the previous loader, but everything
that goes through the class loader did not: loadRuleFromClassPath could
not find rule classes that are only visible to the class loader passed
to loadResourcesWith, and the ruleset failed to load with a
ClassNotFoundException.

Build the wrapper with the previous loader's class loader so class and
classpath resource resolution keep using it.

Co-authored-by: Andreas Dangel <andreas.dangel@pmd-code.org>

Coverage Stats

19518 of 25584 branches covered (76.29%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 2 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

42288 of 52351 relevant lines covered (80.78%)

0.82 hits per line