pmd / pmd / 724

79%

Build Type

push

github

Committed by web-flow

Commit Message

[java] Fix #6393: UnusedPrivateMethod FP on overloaded methods when overload resolution fails (#6947)

What:
  UnusedPrivateMethod reported a false positive on one of several overloaded
  private methods when a call's argument is the return value of a method
  declared in a type that is not on the auxiliary classpath (unresolved
  receiver/return type), causing overload resolution to fail.

Root cause:
  When overload resolution fails (OverloadSelectionResult#isFailed()), the
  selected method symbol is an arbitrary fallback, not the actually-called
  overload. The rule only branched into the conservative "whitelist all
  same-named candidates" path when the symbol was unresolved
  (JExecutableSymbol#isUnresolved()). A failed-but-resolved fallback
  therefore caused only that one overload to be marked used, flagging the
  remaining overload(s) as unused.

Fix:
  Treat a failed overload selection like an unresolved call, so all
  same-named private method candidates are whitelisted when the receiver
  may be an instance of the analysed class (existing handleUnresolvedCall
  logic). This is consistent with the rule's existing false-positive-avoiding
  trade-off for unresolved calls.

Testing:
  New test case in UnusedPrivateMethod.xml reproducing the issue (expects 0
  violations). Full UnusedPrivateMethodTest: 111 tests, 0 failures, 0 errors
  (2 pre-existing skipped).

Signed-off-by: 付典 <fudianchn@gmail.com>
Co-authored-by: Sören Glimm <git@uncleowen.de>

Coverage Stats

19521 of 25582 branches covered (76.31%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

19 existing lines in 1 file now uncovered.

42281 of 52342 relevant lines covered (80.78%)

0.82 hits per line