supabase / supabase-swift / 31793857584

88%

push

github

fix(auth,storage,realtime,helpers)!: narrow Codable conformances to their actual usage direction (#1209)

* docs: add Codable conformance guideline to AGENTS.md

Codifies the convention behind SDK-1473 so future additions default to
the direction a type is actually used in, instead of reaching for full
Codable by habit.

* refactor(auth): narrow Codable conformances for response types

Narrow the following types to Decodable, since they are only decoded:
- AuthResponse, SSOResponse (delete hand-rolled encode methods)
- OAuthAuthorizationClient, OAuthAuthorizationUser, OAuthAuthorizationDetails
- OAuthRedirect, OAuthGrant
- OAuthClientType, OAuthClientRegistrationType, OAuthClient
- JWK, JWKS, JWTHeader
- JWTClaims (delete hand-rolled encode method), AudienceClaim (delete handler)
- PasskeyListItem

Drop Codable entirely from OAuthResponse and top-level Provider enum, since
they are never encoded or decoded through Codable machinery.

Replace the test that was re-encoding JWKS with a direct JSON literal.

* refactor(auth): narrow Codable conformances for request types

Narrow the following types to Encodable, as they are only ever
encoded into outgoing request bodies, never decoded:

- OpenIDConnectCredentials and its nested Provider enum
- AuthMetaSecurity
- Web3Chain
- Web3Credentials
- UserAttributes
- UserCredentials (internal)
- SignUpRequest (internal)
- OTPParams (internal)
- RecoverParams (internal)

* refactor(storage): narrow Codable conformances for vector and image-transform types

Vector-store types (VectorBucket, VectorIndex, VectorIndexSummary, VectorMatch) are only ever decoded from API responses, so narrow them to Decodable. VectorEntry is only ever encoded when sent to the API, so narrow it to Encodable. Image-transform and sort types (ResizeMode, ImageFormat, SortOrder) are only sent to the API and never decoded internally, so narrow them to Encodable-only and delete their now-dead init(from:) methods. Update tests to match.

* refac... (continued)

6 of 6 new or added lines in 2 files covered. (100.0%)

8872 of 10279 relevant lines covered (86.31%)

43.53 hits per line