agama-project / agama / 31787671060

83%

master: 83%

Build Type

push

github

Committed by web-flow

Commit Message

fix(web): stop binding new connections to the loopback device (#3821)

## Problem

While working in a network form upcoming improvement, it was discovered
that creating a connection and setting its device binding to "Chosen by
name" (or "Chosen by MAC address") starts the form off bound to `lo`.
The selector shows `lo` even though it never offers it as an option, and
accepting the form submits a connection bound to the loopback device,
which cannot reach anything.


The form seeds its device fields from the first device the system
reports, and that is the loopback one. The selectors do exclude it from
their options, but by then the value is already set, and a value that is
not among the options is simply printed as-is.

## Solution

The list of devices a connection is never bound to now has one home in
the form, and it is used both for the values the form starts from and
for the options the selectors offer, so the two cannot drift apart.

## Details

The test fixtures were part of why this went unnoticed: they mocked a
device list with no loopback device. It is now first in that list, as
the backend reports it, and adding it turned an existing test red,
showing the payload carried `iface: "lo"`. A new test covers the case
directly.

## Testing

- `npm run test -- src/components/network`, `npm run check-types` and
`npm run eslint` pass.
- Manually: create a connection, set the device binding to "Chosen by
name", and check the selector shows a real device. Same with "Chosen by
MAC address".

Coverage Stats

4935 of 6837 branches covered (72.18%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

25721 of 29947 relevant lines covered (85.89%)

124.28 hits per line