decentraland / lamb2 / 31700073591

63%

main: 63%

push

github

fix: derive profile identity fields from the entity pointer (#472)

The `userId` and `ethAddress` fields of an avatar are metadata copied from the
deployment, so they can disagree with the pointer the profile is stored under.
They were passed through to the response untouched, while consumers use them as
the address of the profile.

Both fields are now set from `entity.pointers[0]`, which is already in scope and
used for every ownership lookup. Default profiles are exempt because their
pointer is a name rather than an address, and their deployed value is the one
clients expect.

468 of 981 branches covered (47.71%)

Branch coverage included in aggregate %.

1660 of 2396 relevant lines covered (69.28%)

77.23 hits per line