FROSADO / onecloudriver / 31659366364

80%

push

github

fix(service): resolve binary robustly for service install ExecStart (#55)

* fix(service): resolve binary robustly for service install ExecStart

service install resolved the ExecStart binary from os.Args[0] with
filepath.Abs, which could produce a CWD-relative path or a go test binary
path, so the generated unit could fail with 203/EXEC. Resolve it via
exec.LookPath, reject *.test binaries, and fail fast before writing the
unit. Document the local testing flow in CONTRIBUTING.md and the manuals.

🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>

* fix(service): annotate gosec false positives in resolveBinary helpers

gosec flags os.Stat in isExecutableFile (G703, taint analysis) and the
0755 WriteFile in the writeExecutable test helper (G306). Both are false
positives: the stat is the validation step itself and the test helper
writes an executable on purpose. Add #nosec annotations so Lint and
Security Audit pass.

🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>

---------

Co-authored-by: Codebuff <noreply@codebuff.com>

33 of 40 new or added lines in 1 file covered. (82.5%)

3504 of 4793 relevant lines covered (73.11%)

503.4 hits per line