kubeflow / sdk / 31617266914

86%

push

github

fix(trainer): assert behavior in Kubernetes get_runtime_packages test (#567)

test_get_runtime_packages wrapped the call in a bare try/except and only
asserted the exception type inside the except block. This let both cases
pass without verifying the contract: the FAILED (BuiltinTrainer) case never
checked that a ValueError was actually raised, so it would pass silently if
the guard were ever removed, and the SUCCESS case asserted nothing about the
call at all.

Branch on expected_status like the sibling list_runtimes test: use
pytest.raises for the failure case, and assert the success call returns None
(get_runtime_packages runs a TrainJob and streams logs without returning a
value). Verified red/green by temporarily removing the ValueError guard in
the backend: the old test still passed, the rewritten test fails.

Signed-off-by: Anas Khan <83116240+anxkhn@users.noreply.github.com>

4 of 4 new or added lines in 1 file covered. (100.0%)

6365 of 7438 relevant lines covered (85.57%)

1.71 hits per line