agama-project / agama / 31601111717

83%

Build Type

push

github

Committed by web-flow

Commit Message

fix(service): activate unknown zFCP LUNs (#3804)

## Problem

On systems using non-NPIV-enabled zFCP controllers, zFCP LUNs provided
by storage systems other than the IBM DS8000 family (for example, IBM
FlashSystem) may not be listed for enablement after the corresponding
zFCP controller has been activated. And unknown LUNs cannot be currently
activated with Agama neither loading a JSON config file nor using the
UI. Trying to load a config with unknown LUNs makes Agama to report an
issue.

There are some workarounds. For example, to manually activate the LUNs
on booting time by adding `rd.zdev` kernel boot options:

~~~
rd.zdev=zfcp-lun,0.0.5223:0x500507681015a2a6:0x0186000000000000
rd.zdev=zfcp-lun,0.0.5323:0x500507681015a2b2:0x0186000000000000
~~~ 

Or after loading the installer, using the command line to manually
activate the devices (`chzdev`) and then rescanning the devices with the
"Rescan" buntton in the Agama UI.

~~~
$ chzdev -ea 0.0.5223:0x500507681015a2a6:0x0186000000000000
$ chzdev -ea 0.0.5323:0x500507681015a2b2:0x0186000000000000
~~~

https://bugzilla.suse.com/show_bug.cgi?id=1271376

## Solution

Allow indicating unkown LUNs in the Agama JSON config. Now, Agama tries
to activate the LUNs instead of reporting an "unknown LUN" issue.

Example:

~~~
$ agama config edit

{
  "zfcp": {
    "devices": [
      {
        "channel": "0.0.fc00",
        "wwpn": "0x500507630b101216",
        "lun": "0x0001000000000000",
        "active": false
      }
    ]
  }
}
~~~

The LUN activation in the UI is still limited to known LUNs only.

Coverage Stats

4917 of 6862 branches covered (71.66%)

Branch coverage included in aggregate %.

18 of 18 new or added lines in 1 file covered. (100.0%)

2 existing lines in 2 files now uncovered.

26610 of 30903 relevant lines covered (86.11%)

120.46 hits per line