decentraland / comms-gatekeeper / 31599212132

86%

main: 86%

Pull #288

github

fix: publish the ended event for every expired community voice chat

The expiration sweep resolved each room's participant count from
`getAllActiveCommunityVoiceChats`, but that query only returns rooms that
still have an active moderator — which is exactly what an expiring room
does not have. Every expiry therefore looked up a count of 0, and
`publishCommunityStreamingEndedEvent` treats 0 as "already torn down" and
stays quiet. The result: the most common silent end of a community voice
chat (the host drops off the network and the room expires five minutes
later) published nothing at all.

`deleteExpiredCommunityVoiceChats` already returns one row per deleted
participant, so it now reports the count alongside each room name. That
makes the count exact — a read taken before or after the DELETE would race
with participants joining and leaving — and removes the separate query that
could never see the rooms it was asked about.

`getBulkCommunityVoiceChatParticipantCount` had no other caller and is gone.

1145 of 1455 branches covered (78.69%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 2 files covered. (100.0%)

3119 of 3515 relevant lines covered (88.73%)

77.97 hits per line