supabase / supabase-flutter / 31509351637

89%

Build Type

push

github

Committed by web-flow

Commit Message

feat!: use DateTime for all timestamp fields (#1663)

Closes #1449

## What

Every timestamp the SDK returns is now a `DateTime` in UTC, parsed once
when the response is decoded, instead of a raw ISO 8601 `String` or a
Unix timestamp `int`.

| Type | Fields | Before | After |
| --- | --- | --- | --- |
| `Session` | `expiresAt` | `int?` (Unix seconds) | `DateTime?` |
| `User` | `createdAt` | `String` | `DateTime` |
| `User` | `confirmationSentAt`, `recoverySentAt`, `emailChangeSentAt`,
`invitedAt`, `confirmedAt`, `emailConfirmedAt`, `phoneConfirmedAt`,
`lastSignInAt`, `updatedAt` | `String?` | `DateTime?` |
| `UserIdentity` | `createdAt`, `lastSignInAt`, `updatedAt` | `String?`
| `DateTime?` |
| `OAuthClient` | `createdAt`, `updatedAt` | `String` | `DateTime` |
| `Bucket` | `createdAt`, `updatedAt` | `String` | `DateTime` |
| `FileObject` | `createdAt`, `updatedAt`, `lastAccessedAt` | `String?`
| `DateTime?` |
| `FileObjectV2` | `createdAt` / `updatedAt`, `lastAccessedAt`,
`lastModified` | `String` / `String?` | `DateTime` / `DateTime?` |
| `PaginatedFile` | `createdAt`, `updatedAt` | `String?` | `DateTime?` |

The wire format is unchanged: `toJson()` still writes ISO 8601 strings
for the `User` timestamps and Unix seconds for `Session.expires_at`, so
sessions persisted by v2 are still readable.

## How

Parsing now lives in `supabase_common` (`parseIso8601`,
`tryParseIso8601`, `parseUnixSeconds`, `tryParseUnixSeconds`,
`dateTimeFromUnixSeconds`, `unixSecondsFromDateTime`) and replaces the
per-type parsers that had grown in `mfa.dart`, `passkey.dart`,
`custom_oauth_provider.dart` and `storage_client/types.dart`. All of
them normalize to UTC, so the timestamps in `Factor`, `Passkey`,
`AuthMFAChallengeResponse`, `AMREntry`, `AnalyticsBucket` and
`CustomOAuthProvider` are consistent with the newly converted ones.

Three consequences worth calling out:

- **Unix timestamps are UTC now.** `AuthMFAChallengeResponse.expiresAt`,
the passkey challenge expiries ... (continued)

Coverage Stats

96 of 99 new or added lines in 11 files covered. (96.97%)

59 existing lines in 4 files now uncovered.

5671 of 6483 relevant lines covered (87.47%)

4.05 hits per line