supabase / supabase-flutter / 31495823238

89%

push

github

refactor(gotrue)!: drop the pre-2024-01-01 API version fallbacks (#1685)

## What

Removes GoTrue's runtime API version negotiation and the two
error-parsing fallbacks it drove.

`GotrueFetch._handleError` used to read the `x-supabase-api-version`
response header, parse it into a timestamp, and compare it against
`2024-01-01` to decide which field carried the error code:

- `2024-01-01` or newer: read `code`
- older, or header absent: read `error_code`

If neither field produced a code, it then reconstructed
`AuthWeakPasswordException` by inspecting a bare `weak_password` object
in the body and checking its `reasons` were all strings, covering
servers old enough to predate error codes entirely.

Both paths are gone. The error code is now always read from `code`, and
`AuthWeakPasswordException` is only thrown when the server names
`weak_password` explicitly.

The client still sends `x-supabase-api-version: 2024-01-01` on every
request, it just no longer inspects what comes back. With nothing left
comparing versions, `ApiVersion` and `ApiVersions` are removed and the
header value moves to a plain `Constants.apiVersion`.

## Breaking change

gotrue now requires a GoTrue server on API version `2024-01-01` or
newer. Hosted Supabase projects have been well past this for a long
time, so in practice this only affects self-hosted setups pinned to an
older GoTrue.

Against one of those, an auth failure still throws `AuthApiException`
with the correct message and status code, but:

- `AuthException.code` is `null` instead of the value from `error_code`
- a weak password surfaces as a plain `AuthApiException` rather than
`AuthWeakPasswordException`

Upgrading the server restores both.

The public `ApiVersions` class and its `ApiVersions.v20240101` field are
removed. Nothing replaces them; they existed only to drive the
comparison above.

`MIGRATION.md` gains a section under v2 to v3, and the two `ApiVersions`
entries are dropped from `sdk-compliance.yaml`.

## No... (continued)

5 of 5 new or added lines in 1 file covered. (100.0%)

5634 of 6449 relevant lines covered (87.36%)

4.06 hits per line