iotaledger / iota / 31449538591

70%

Build Type

push

github

Committed by web-flow

Commit Message

fix(consensus): deliver cache-hit headers instead of swallowing them (#12597)

# Description of change

The header synchronizer's verified cache recorded a header's digest as
soon as its signature verified, and a later cache hit removed the header
from the response entirely. A header dropped after the insert
(out-of-window unrequested extra, far-future bound, per-slot cap)
therefore became unfetchable through the synchronizer — every refetch,
including an explicit by-digest request, was swallowed.

A cache hit now only skips the signature check; the header is still
deserialized and delivered. Duplicate suppression stays with the block
manager, which filters against real state (accepted or suspended).

## Links to any relevant issues

fixes iotaledger/iota-private#491

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] Patch-specific tests (correctness, functionality coverage)
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] I have checked that new and existing unit tests pass locally with
my changes

Coverage Stats

133 of 146 new or added lines in 2 files covered. (91.1%)

2536 existing lines in 77 files now uncovered.

168892 of 242374 relevant lines covered (69.68%)

466365.72 hits per line