conventional-changelog / conventional-changelog / 31434056393

86%

push

github

fix(git-client): end the options list before caller provided values (#1535)

A value starting with a dash was parsed by git as an option, so
`checkout('--pathspec-from-file=/tmp/secret')` made git read that file and
report its lines in the error output, which `exec` turns into the message of
the thrown error. A commits or tags range could reach `git log --output=<file>`
and write the log to an arbitrary path.

`--end-of-options` is used rather than `--`: in `git checkout` the latter means
that pathspecs follow, which is why it was removed in 993c1fdd, and restoring
it would break branch switching again.

782 of 1017 branches covered (76.89%)

1 of 1 new or added line in 1 file covered. (100.0%)

1135 of 1317 relevant lines covered (86.18%)

80872.39 hits per line