lsm / HyperNeo / 31338108314

79%

Build Type

push

github

Committed by web-flow

Commit Message

feat(space): add codex_review_approved preset over the github connector (#2409)

Adds the codex review gate as a declarative built-in preset (epic #2299
workflow node — over the new `getCodexApproval` github connector op.

The op resolves the PR (with a workspace-branch fallback that propagates
failures rather than swallowing them), enforces a github.com / GH_HOST
allow-list before any gh call, resolves the current head, fetches the PR
reviews, and — when a codex review matches — re-resolves the head to close
the resolution/reviews TOCTOU window (retryable if it moved).

`createCodexApprovalValidator` is a plain L4 decision with zero engine
special-casing: allow when a codex bot leaves an APPROVED review on the
current head (commit_id === head SHA) — the head-specific signal codex
actually emits (mirroring merge-pr-validator); map a connector lookup
failure to retryable (rate limit / transient 5xx / DNS / helper timeout) or
terminal block (truncation / not-found / auth); otherwise `retryable_block`.
It binds the checked PR to the run via the engine-injected authoritative run
PR (a `runPrUrl` on the hook context on BOTH the hook and gate dispatch
paths, resolved from gate data + hook state + artifacts by the same resolver
merge / get_pr_diff use) — a caller-supplied or branch-discovered pr_url
naming a different PR is rejected. A PR-level +1 reaction is intentionally
not accepted (not head-bound). No wait-state, timeout, or safety valve —
engine retry scheduling is the only timer. Registered in production as
`codex_review_approved`.

Also classifies transient transport/server failures (HTTP 5xx, timeouts, DNS)
and the helper kill-timer firing as retryable in the shared `runGhJson`
(deterministic truncation stays terminal), so a brief GitHub stall never
terminally clears a queued handoff.

Drops the spike-era `createCodexReviewBotValidator` + `pollUntilAllow`
composition primitive (no production consumers) that the new preset replaces.

Scope note: the ... (continued)

Coverage Stats

20389 of 57564 branches covered (35.42%)

Branch coverage included in aggregate %.

14 of 89 new or added lines in 9 files covered. (15.73%)

5 existing lines in 4 files now uncovered.

30297 of 68100 relevant lines covered (44.49%)

281.68 hits per line