lsm / HyperNeo / 31294132063

80%

push

github

feat(space): append-only workflow definition version history (RFC §4 Phase 1) (#2412)

* feat(space): append-only workflow definition version history (RFC §4 Phase 1)

First slice of Phase 1 of the data-defined workflow engine RFC (#2396):
an immutable, append-only space_workflow_definition_versions history plus a
deterministic content-hash definition_version for each persisted workflow,
distinct from the template-portable template_hash (captures the row's actual
content incl. resolved agent IDs). Shadow mode — populated on create/update
via the workflow repository, no run read resolves through it yet.

Migration 180 (guarded, idempotent) + createTables baseline + test-helper sync.
No FK to space_workflows (orphan/tombstone for individual-workflow deletion);
FK space_id ON DELETE CASCADE cleans version payloads on whole-Space deletion.
backfillExistingDefinitionVersions() captures pre-existing heads at startup so
a post-rollout edit can't erase the rollout-time definition.

Tests: migration idempotency/FK, hash determinism + volatility exclusion,
append-only idempotency, create/update/updateNodeToolGuards integration,
orphan-safe delete, space-cascade, and startup backfill.

* fix(space): backfill keys on current head hash, not just version existence

Review follow-up (codex P2): the startup backfill's NOT EXISTS (any version)
predicate could not repair a partial write — a head committed whose version
append was swallowed leaves the workflow with an older version but missing its
current head's, and the predicate would skip it forever. Key the backfill on
the current head's computed hash so the current head is always captured at
startup (idempotent). Adds a partial-write repair test.

Atomic head+version writes (which would eliminate the partial-write window and
restore a cheaper predicate) are deferred to the Phase-1 read cutover's
transactional model (RFC §6.1).

* fix(space): harden startup backfill + strip non-behavioral fields from version hash

R... (continued)

20312 of 57287 branches covered (35.46%)

Branch coverage included in aggregate %.

51 of 59 new or added lines in 5 files covered. (86.44%)

30170 of 67741 relevant lines covered (44.54%)

279.61 hits per line