iotaledger / iota / 31288409572
70%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 1062
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 69.48% (+0.003%) from 69.477%
31288409572

push

github

web-flow 
feat(typed-store): add `TaggedDBMap` (#12448)

# Description of change

Three `typed-store` additions, all self-contained and with no callers
changed yet:

- **`TaggedDBMap`** — several typed maps share one column family, each
with a tag byte prefixed to its keys (the big-endian fixint
serialization of `(tag, key)` is exactly that), so each map occupies a
contiguous key range. Useful for sets of tables that are always created
and dropped together: one column family instead of one per table keeps
the column-family and SST-file counts low. Every read is scoped to the
map's tag — full scans iterate the tag's key prefix, ranges are
two-sided within it — so rows of other tags never surface and their
differently-typed values are never deserialized.
- **`Database::create_cf`** — create a column family at runtime,
mirroring the existing `drop_cf`. `RocksDB::cf_names` becomes an
`RwLock<Vec<String>>` so runtime creates and drops keep it in sync,
which in turn keeps `flush_all` covering the current set of column
families.
- **Slow-batch-write threshold scales with batch size** — the warning
fired at a flat 1s regardless of how much was written, so large bulk
batches logged `very slow batch write` as a matter of course. The
threshold is now `batch_size / 32 MiB/s`, floored at 1s, so a small
write taking a second is still reported as a genuine stall. `batch_size`
is included in the log line.

`DBMap::reopen`'s `is_deprecated` parameter is renamed to
`skip_metrics_reporting` — it always meant "don't spawn the
per-column-family metrics task", and the second reason to skip it is a
large set of rarely-touched column families. Behaviour is unchanged.

## Links to any relevant issues

None — groundwork for upcoming work that needs many short-lived tables.

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] Patch-specific tests (correctness, functionality coverage)
- [x] I have added tests that prove my ... (continued)

167448 of 241003 relevant lines covered (69.48%)

470542.11 hits per line

Coverage Regressions

Lines Coverage ∆ File
15
93.45
 -0.59% crates/starfish/core/src/authority_service.rs
7
79.25
 -1.1% crates/iota-types/src/crypto.rs
7
95.67
 -0.38% crates/starfish/core/src/transactions_synchronizer.rs
4
74.89
 0.43% crates/iota-network/src/randomness/mod.rs
2
86.85
 0.5% crates/iota-core/src/storage.rs
2
90.76
 -0.22% crates/iota-network/src/state_sync/mod.rs
2
96.05
 -0.22% crates/starfish/core/src/shard_reconstructor.rs
1
86.11
 0.0% crates/iota-cluster-test/src/test_case/native_transfer_test.rs
1
91.12
 0.12% crates/iota-core/src/authority/authority_per_epoch_store.rs
1
89.35
 0.34% crates/iota-core/src/connection_monitor.rs
1
92.1
 -0.11% crates/iota-core/src/epoch/randomness.rs
1
91.77
 0.38% crates/iota-core/src/execution_cache/writeback_cache.rs
1
85.78
 -0.09% crates/iota-json-rpc/src/read_api.rs
1
89.24
 0.0% crates/iota-network/src/discovery/mod.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest+simtest - 31288409572.1 1062
69.48
 GitHub Action Run
Source Files on build 31288409572