lsm / HyperNeo / 31283397313

80%

Build Type

push

github

Committed by web-flow

Commit Message

fix(web): make reconnect recovery session-scoped [#872] (#2407)

* fix(web): make reconnect recovery session-scoped [#872]

Phase 2 of mobile agent-session recovery, building on #871 (#2395).

Each SessionStore now tracks a per-session `isRecovering` flag (token-guarded
against duplicate/late reconnect events) that is distinct from initial-load
and from a genuine load failure. A shared `performRecovery` rejoins
`session:${id}`, re-establishes the messages LiveQuery (fresh snapshot re-syncs
deltas missed while paused/dropped), and refreshes state with retainOnError —
used by BOTH the transport-reconnect handler and the soft-staleness resume path
(refreshAllSessionStores now drives `recover()`, so Safari background-resume
re-syncs messages too, not just state).

ChatContainer keeps the transcript visible (loading skeleton cannot relapse
during recovery), gates the composer on session-ready — not merely when the
socket reports connected — and shows a non-blocking "Reconnecting…" indicator.

Tests: isRecovering lifecycle, duplicate reconnect events, soft-resume message
re-subscribe + retainOnError, late-error isolation after a session switch,
independent A/B recovery, atomic channel+messages restore, and ChatContainer
source guards. Runtime-verified on a mobile Safari viewport via the repo's WS
close/restore helpers: transcript stays visible, isRecovering flips true on
drop and clears on restore, activeSessionId never drifts, no Retry screen.

* fix(web): address #2407 review — loading skeleton, failed resubscribe, drop zone

Three review fixes for session-scoped reconnect recovery:

1. Keep incomplete initial loads behind the skeleton. A disconnect landing
   after `state.session` loads but before the first messages snapshot flipped
   `isRecovering` and hid the skeleton, rendering "No messages yet" for a
   conversation whose messages were still in flight. Extracted a testable
   `computeChatLoading` and gated the skeleton-bypass on
   `isRecovering && ... (continued)

Coverage Stats

19893 of 57056 branches covered (34.87%)

Branch coverage included in aggregate %.

110 of 122 new or added lines in 3 files covered. (90.16%)

469 existing lines in 35 files now uncovered.

29580 of 67556 relevant lines covered (43.79%)

208.67 hits per line