lsm / HyperNeo / 31282701944

80%

push

github

fix(web): make workflow graph node clicks resolve by node identity (#2389)

* fix(web): make workflow graph node clicks resolve by node identity

Clicking an unstarted workflow node opened a previously-active node's
session because handleNodeClick matched activity members by slot name
only and fell back to the first unrelated node-agent session. Node
selection now resolves strictly by the clicked persisted node ID plus
declared agent slot via a pure resolver (node-click-resolver):

- exactly one live match -> open that session
- unstarted single slot -> its own pending-agent overlay (activates
  only that slot on first send)
- multi-agent / multi-slot ambiguous -> a choice overlay; zero-agent
  node -> an empty state
- spawned post-approval (merger) session is tied to its node via
  task.postApprovalSessionId once available; nullable rollout identity
  never falls back to another node

* fix(web): thread workflowNodeId through pending activation; honor workflow-level postApproval

Address review P1 + P2 on #2389.

P1 — the identity bug survived on the send path: activate_slot dropped the
clicked node ID, so pushOverlayHistoryForPendingAgent carried only the slot
name and the backend activated the FIRST node declaring it. Now the node ID
flows end-to-end:
- resolver activate_slot / NodePendingSlot carry nodeId
- router pushOverlayHistoryForPendingAgent + SpaceOverlayTaskContext
- SpaceIsland pendingAgent -> ChatContainer -> spaceStore.activateTaskNodeAgent
- daemon space.task.activateNodeAgent forwards workflowNodeId into BOTH
  getSubSessionByAgentName and ensureWorkflowNodeActivationForAgent
- sendTaskMessage/routeToNodeAgents scope matches + activation by workflowNodeId
- inline composer (composerTargets.nodeId) and dropdown carry it too

P2 — legacy workflows use workflow-level postApproval (no node route);
handleNodeClick now falls back to workflow.postApproval.targetAgent, mirroring
collectPostApprovalRoutes, so the merger session resolves.

Test... (continued)

19905 of 56960 branches covered (34.95%)

Branch coverage included in aggregate %.

201 of 375 new or added lines in 12 files covered. (53.6%)

29598 of 67448 relevant lines covered (43.88%)

236.24 hits per line