coreui / coreui-pro / 31273027350

93%

main: 94%

push

github

fix(scss): keep the CSS-to-JS signals out of $prefix (#725)

Two custom properties exist only so a stylesheet can tell a plugin something:
`--cui-position`, which the dropdown reads to learn whether its menu is
end-aligned, and `--cui-is-mobile`, which the sidebar sets inside a media query
and reads back to detect its mobile behavior. Both were emitted through
`$prefix` while both are read from JavaScript by a name spelled out in full, so
a build that changes the prefix left the stylesheet writing `--bs-…` and the
plugin reading `--cui-…`: the dropdown stopped seeing its alignment and the
sidebar stopped seeing that it was mobile. Measured in Chromium against a
`$prefix: bs-` build — both read empty; with this change both read correctly.

They are signals, not tokens: neither is documented, neither is meant to be set
by hand, and a configurable name is exactly what lets the two sides disagree.
Same reasoning as `--cui-range-slider-track-from` in #724.

The compiled stylesheet is unchanged at the default prefix — `--#{$prefix}position`
with `cui-` already produced `--cui-position`, so this is a no-op for every build
that does not reconfigure it.

4255 of 4805 branches covered (88.55%)

Branch coverage included in aggregate %.

8265 of 8660 relevant lines covered (95.44%)

364.41 hits per line