dangernoodle-io / breadboard / 31270695615

97%

push

github

fix: preserve every line of a log burst through egress (B1-1440) (#1256)

- bb_log_event's forwarder queue already preserved a burst (each line is
  a distinct queued message, drained one at a time) -- the loss was one
  step later: a bare bb_data_touch("log") per line let bb_data_http's
  EVENT-ring generation-compare CLAIM step coalesce every line between
  two push_pump() calls down to just the latest one, same as STATE's
  dirty-mask.
- s_forwarder_task now calls bb_data_http_notify_push() right after the
  stash write (order matters: stash first, notify second), draining
  each line into the shared EVENT ring before the next queued line can
  overwrite s_last_log_json -- safe because this task is the single
  writer of that stash and blocks serially on xQueueReceive() between
  lines.
- swap the "log" bb_data_http binding from STATE to EVENT kind at both
  composition roots (examples/floor/main/floor_app.c,
  examples/smoke/main/bb_wire.h) -- per the EVENT-vs-STATE
  reconstructibility rule, case (a): a log line is per-occurrence
  payload that varies and matters individually, it does not fold into
  a counter + latest-value field.
- extend test_bb_data_http.c's push_pump ring-feed proof to N
  sequential bumps, each immediately pumped, asserting N distinct
  ring entries delivered in order -- mutation-verified: moving the
  pump call outside the per-line loop (bump N, pump once) reproduces
  the coalescing bug and fails the new assertion (5 expected, 1
  observed); restoring the per-line pump call passes again.

Hardware evidence (pre-fix vs post-fix build, same board, same test):
- BEFORE: 33 of 40 distinct sequence-numbered log lines delivered; seq
  2, 5, 10, 19, 21, 32, 37 silently lost.
- AFTER: 40 of 40, zero missing, zero duplicated.
- Stack: nesting push_pump() inside the forwarder OVERFLOWED the
  original 3072-byte stack -- a real Guru Meditation panic (unhandled
  debug exception, corrupted backtrace) at ~992 lines with a client
  att... (continued)

8519 of 9038 branches covered (94.26%)

Branch coverage included in aggregate %.

14263 of 14418 relevant lines covered (98.92%)

2608.14 hits per line