decentraland / realm-provider / 31258986838

57%

main: 51%

Pull #89

github

fix: address PR review feedback — stale cache, circuit breaker, tests

P1 — stale cache correctness:
  Track whether any catalyst returned a successful HTTP response
  (hadSuccessfulResponse). Only preserve stale data when ALL catalysts
  failed due to transport errors or were skipped by an open circuit.
  When catalysts explicitly report healthy=false / acceptingUsers=false,
  the cache now correctly updates to [] instead of serving stale
  "healthy" data.

P2 — circuit breaker consecutive counting:
  Move recordSuccess() call before the healthy/acceptingUsers check.
  Any successful HTTP response (even with healthy=false) now resets
  the transport failure counter, so the circuit only opens on truly
  consecutive transport failures.

P2 — circuit breaker open/cooldown test coverage:
  Add deterministic test using configurable CATALYSTS_CACHE_TTL_MS,
  CB_FAILURE_THRESHOLD, and CB_COOLOFF_MS env vars (short values for
  fast test execution). Verifies the full cycle: 3 failures → circuit
  opens → catalyst skipped → cooloff expires → catalyst retried.

Also add tests for:
  - Cache NOT preserving stale data on explicit unhealthy responses
  - recordSuccess resetting failure count on non-accepting responses

86 of 120 branches covered (71.67%)

Branch coverage included in aggregate %.

49 of 51 new or added lines in 1 file covered. (96.08%)

191 of 365 relevant lines covered (52.33%)

17.78 hits per line