dangernoodle-io / breadboard / 31236341547

97%

push

github

feat: add variant_ladder fence family to stop new API ladders (B1-1461) (#1252)

- scans components/*/include/*.h for a suffixed public function
  (_ex/_ex2/_ex3/_named/_with_*/_handle/_ref/_sized/_full) whose
  un-suffixed base name is also declared public in the same component's
  header set -- both rungs must exist for it to be a ladder
- typed-accessor suffixes (_u8/_u16/_u32/_i32/_f32/etc.) are excluded
  before any ladder-suffix pattern is tried
- baseline starts empty (B1-1434 already removed every known ladder) --
  this is a pure no-new-ladders gate, not a shrink-only exception list
- scan surfaces one pre-existing, un-baselined finding:
  bb_serialize_json_render_ref() alongside bb_serialize_json_render() --
  intentionally left unresolved for review, not decided here

review round 2 fixes:
- fix _FN_DECL_RE (MUST-FIX): the pointer slot only matched directly
  after the first return-type word, so type *name(...) -- star attached
  to the NAME, the dominant style for pointer-returning public API in
  this tree -- never matched, and the fence silently passed 0 markers on
  16 real headers using this style. Widened so a * may attach to ANY
  prefix word and sit directly against the name with no space; covers
  void *foo(), bb_foo_t *foo(), const bb_foo_t *foo(), unsigned char
  *foo(), bb_foo_t * foo(), and the existing bb_err_t foo() shape
- drop const/volatile/register from _FN_DECL_SKIP_KW: they are
  legitimate return-type qualifiers on real declarations, not a signal
  the line isn't a function decl -- the previous list silently excluded
  every const-qualified public declaration (e.g. every const-returning
  pointer accessor) from the scan entirely
- add TestPointerReturnLadderFires + TestPointerReturnWithNoBaseSiblingNotFlagged
  covering every pointer-return spelling above, both fires and
  no-base-sibling non-fire
- re-verified against the real tree: variant_ladder still 0 markers /
  0 new -- the widened regex did not surface a real l... (continued)

8544 of 9084 branches covered (94.06%)

Branch coverage included in aggregate %.

14272 of 14427 relevant lines covered (98.93%)

2593.81 hits per line