dangernoodle-io / breadboard / 31235142339

97%

push

github

refactor: collapse bb_serialize_json_render_ref into bb_serialize_json_render (#1251)

12th variant-ladder finding from the B1-1434 audit: bb_serialize_json_render()
and bb_serialize_json_render_ref() coexisted as two public entry points, the
wider one adding REF resolution (resolve/resolve_ctx) without either
forwarding into the other. Fold resolve/resolve_ctx into the existing
bb_serialize_json_render_cfg_t (extended in B1-1437) rather than keeping a
second entry point, so the component is consistently config-struct-shaped.

bb_serialize_json_render_ref() had zero production callers -- only its own
two host tests, updated to the cfg-struct form. The private
bb_json_format_render() adapter (bb_serialize_json_format.c) is unaffected:
it already builds a cfg struct with resolve left at its NULL zero-init
default.

Adds a zero-default-trap pinning test: resolve==NULL with a non-NULL
resolve_ctx is inert (mirrors bb_serialize_walk_cfg_t's own convention),
mutation-verified.

Size measurement (symbol-diff; measured via xtensa-esp-elf-gcc-nm on
examples/smoke/.pio/build/esp32/firmware.elf): bb_serialize_json IS linked
(contrary to an earlier false claim that found zero symbols). Real measurements:

  bb_serialize_json_render      32 -> 34 bytes  (+2)
  bb_json_render_impl          126 -> 126       (unchanged)
  bb_json_format_render         34 -> 34        (unchanged)
  all 26 other bb_serialize_json* symbols: byte-identical

Net impact: +2 bytes. The function bb_serialize_json_render_ref itself is
absent from both images — it had zero production callers, so the linker
already dropped it; deleting it costs nothing.

Measured by symbol rather than whole-image diff because whole-image
comparison is unreliable in this repo (dependencies.lock is gitignored, so
managed-component versions drift between builds; see B1-1462).

Claude-Session: https://claude.ai/code/session_0119nuE2NZME9y2aYEVJTPB5

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

8544 of 9084 branches covered (94.06%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

14272 of 14427 relevant lines covered (98.93%)

2647.83 hits per line