adobe / spectrum-web-components / 31213822996

96%

push

github

fix(popover): restore focus with preventScroll on close (#6594)

When a light-dismiss popover closes with focus still inside it, focus is
restored to the trigger. The bare focus() call scrolled a trigger that had
been scrolled out of view back into view. Pass { preventScroll: true } to
match the on-open _focusSurface() convention.

Only reached on touch (e.g. iPad): a tap outside on non-interactive content
does not blur the popover, so focus is still inside when it closes and
restoration runs; on desktop the outside mousedown blurs first, skipping
restoration.

6020 of 6464 branches covered (93.13%)

Branch coverage included in aggregate %.

37993 of 39268 relevant lines covered (96.75%)

460.67 hits per line