lsm / HyperNeo / 31196119267
40%

DEFAULT BRANCH: dev
Ran
Jobs 0
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
31196119267

push

github

web-flow 
fix(github-events): drop inactive deployment_status before webhook resolution (#2386)

* fix(github-events): drop inactive deployment_status before resolution

The merge-blocking spec (#2324) fires no event for inactive deployment_status
states. dev already drops inactive in the normalizer, but the webhook path
reached it only AFTER the cooldown gate (spurious 503) and the SHA→PR
resolution call (quota + 503 on failure) — so an inactive delivery (a spec
no-op) could burn a GitHub API request and surface a spurious 503 during
cooldown. handleDeploymentWebhook now returns 202 for inactive as soon as the
payload is parsed, before any gating or resolution. The normalizer check stays
as defense-in-depth for other callers.

Test: inactive returns 202 with zero resolution calls, even during an active
rate-limit cooldown; updated the existing inactive webhook test to the early
202 (the normalizer-level drop remains covered directly in github-normalizer.test.ts).

* fix(github-events): mark webhook received when dropping inactive

Review (P2): the early inactive return regressed webhook health — on dev the
normalizer's null-return sat inside the publish loop, so an inactive delivery
that resolved to ≥1 PR still ran the per-target markWebhookReceived (advancing
last_webhook_at / clearing a transient error); the early drop moved it before
the loop and lost that. Relocated the inactive drop to after the enabled-target
set is computed (still before the cooldown gate and SHA→PR resolution, so the
quota / spurious-503 wins are intact) and call markWebhookReceived for each
target before returning 202 — restoring dev's mark semantics for inactive.

Test now asserts lastWebhookAt advances while resolutionCalls stays 0 and no
503 surfaces during an active rate-limit cooldown.
Source Files on build 31196119267
Detailed source file information is not available for this build.