supabase / supabase-swift / 31194585392

85%

Build Type

push

github

Committed by web-flow

Commit Message

fix(supabase): stop listenForAuthEvents task from leaking SupabaseClient (#1191)

`listenForAuthEvents()` started a `Task` whose body called the instance
method `handleTokenChanged`, implicitly capturing `self` strongly. The
task loops over `auth.authStateChanges`, a stream that never finishes, so
the strong reference was permanent. `deinit` cancels that task, but
`deinit` can only run once the retain count reaches zero -- which the task
itself prevented. Every `SupabaseClient` created without a static
`accessToken` option therefore leaked for the life of the process.

The stream is now resolved before the task starts, so the task no longer
needs `self` to reach `auth`, and `self` is captured weakly. Each
iteration re-acquires the client and exits the loop once it's gone.
Auth-state handling for a live client is unchanged.

The same cycle existed for the cached sub-clients: `rest`, `storage` and
`functions` were handed the `fetchWithAuth`/`uploadWithAuth` method
references, which capture `self`, and are themselves cached in
`mutableState`. Those are now closures capturing only the dependencies
they need (the `URLSession` and the access-token provider), so touching a
sub-client no longer pins the client either.

Closes #1187

Coverage Stats

26 of 32 new or added lines in 1 file covered. (81.25%)

64 existing lines in 2 files now uncovered.

8773 of 10375 relevant lines covered (84.56%)

1034971.17 hits per line