supabase / supabase-swift / 31194561221

85%

Build Type

push

github

Committed by web-flow

Commit Message

fix(auth): stop auto-refresh task on AuthClient deinit (#1193)

* fix(auth): stop auto-refresh task on AuthClient deinit

`LiveSessionManager`'s auto-refresh loop is stored in a `Task` whose closure
captures the actor, so `self -> Task -> self` keeps the session manager (and
its ticking loop) alive forever once `startAutoRefresh()` is called.

`AuthClient.deinit` only dropped the `Dependencies.instances` entry, and the
only place stopping the loop was `observeAppLifecycleChanges()`, which relies
on an app resign-active notification. That never fires for short-lived clients
(tests, CLI tools, server-side usage) or when auto-refresh was started manually,
leaking a task that keeps refreshing tokens after the client is gone.

`deinit` now also stops auto-refresh through the session manager, capturing only
the session manager (never `self`) in the fire-and-forget task. The session
manager's logger lookup is made lenient, since it now runs after the
dependencies entry is removed.

Closes #1189

* fix(auth): make deinitRemovesDependenciesEntry poll instead of single-yield

deinit now hops to a detached Task to stop auto-refresh, adding scheduling
pressure that made a single Task.megaYield() unreliable for letting the
init-time MainActor task release its reference to self before asserting
deinit happened. Linux CI caught this; poll like deinitStopsAutoRefreshTask
already does instead of asserting after a fixed number of yields.

Coverage Stats

15 of 15 new or added lines in 2 files covered. (100.0%)

17 existing lines in 1 file now uncovered.

8737 of 10340 relevant lines covered (84.5%)

39.58 hits per line