coreui / coreui-pro / 31190689762

93%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(Button): expose aria-pressed on every toggle button (#706)

`aria-pressed` has no default value, so a toggle button that ships without
it is announced as a plain button and its pressed state is never conveyed.
The attribute only appeared once `toggle()` had run, which means the very
first announcement was wrong.

Add the missing attribute to every `[data-coreui-toggle="button"]` on
`DOMContentLoaded`, reading the `.active` class to pick the value, and
document the attribute in the markup examples so it is correct before the
JavaScript runs.

The `setAriaAttribute` helper keeps the boolean-to-string conversion in one
place, which also drops the cast `toggle()` needed to satisfy
`setAttribute`.

Ported from twbs/bootstrap#42797. React's `CButton` already renders
`aria-pressed` whenever `toggle` is set, so no parity fix is needed there.

Coverage Stats

4270 of 4823 branches covered (88.53%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

8285 of 8681 relevant lines covered (95.44%)

362.54 hits per line