FlexMeasures / flexmeasures / 31173041211

84%

Build Type

push

github

Committed by web-flow

Commit Message

Keep device capacities hard unless relaxation is asked for (#2398)

* Keep device capacities hard unless relaxation is asked for

Since relax-constraints started defaulting to True, every scheduling request
got default device breach prices, which turned a directional device capacity
into a soft constraint. That is wrong for the many cases where the capacity
states a physical impossibility rather than an economic preference: a heat pump
with production-capacity 0 was scheduled to produce, because breaching the
device was cheaper than breaching the site.

Restore the opt-in that held before the default flip: fill in default device
breach prices only when relax-capacity-constraints is set, or when
relax-constraints is passed explicitly rather than defaulted. The SoC and site
capacity constraints keep following the default, where softening was the point.

Also stop overwriting explicitly given device breach prices. The guard's own
comment says "unless already set explicitly", but operator precedence tied that
condition to one branch only, and set_default_breach_prices assigns
unconditionally.

This does not fix the case where relaxation was asked for and a capacity of
zero is still meant as a physical statement; see issue #2395.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014qPe5bv41RDTuBVtpdxjWH
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* Point the changelog entry at the right PR number

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* Address review: merge changelog entries, note breach prices, reflow comments

Merge the new changelog entry into the relax-constraints one it qualifies, and
cite both PRs, rather than leaving the reader to stitch two entries together.

Setting a device breach price explicitly also softens that capacity, so say so
where we describe how to relax device capacities, instead of listing only the
two relax fl... (continued)

Coverage Stats

1 of 0 new or added lines in 0 files covered. (NaN%)

9 existing lines in 1 file now uncovered.

17178 of 20459 relevant lines covered (83.96%)

0.84 hits per line