thorstenalpers / Finance.NET / 31162054150

91%

push

github

Log the symbols Yahoo dropped from a batch quote request (#57)

GetQuotesAsync returns only the symbols that resolved, with no warning, no
exception and nothing naming the ones that did not. The leniency itself is
useful - it is what makes a mixed batch survive a bad ticker - but the
omission was unobservable, so a caller doing a scheduled refresh had to diff
requested against returned symbols by hand to find bad tickers.

Diff the request against the response and log a warning naming the symbols
Yahoo returned no data for. Matching ignores casing, since the request is
lower-cased on the way out and Yahoo answers with canonical symbols. The
returned collection is unchanged.

Co-authored-by: thorsten <thorsten@PC>

481 of 615 branches covered (78.21%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 1 file covered. (100.0%)

1758 of 1826 relevant lines covered (96.28%)

92.51 hits per line