IgniteUI / igniteui-webcomponents / 31161261227

98%

Build Type

push

github

Committed by web-flow

Commit Message

fix(date-time-input): only commit value on blur (#1346) (#2312)

`value` no longer moves on every keystroke. While the input is focused the
masked text is the source of truth, and the parsed result reaches `value`
together with `igcChange` when the edit is committed on blur. Use `igcInput`
to observe the value as it is typed - its ISO-string detail is unchanged.

This is what the annotated two-way binding always claimed: framework wrappers
treat `igcChange` as the only signal that `value` moved, so a host that binds
the property held a stale value for the whole editing session. On every
keystroke it re-committed that stale value, and the setter rebuilt the mask
from it, wiping the half-typed input - reported against an igx-grid cell
editor, where an unrelated re-render was enough to trigger it.

The draft alone does not fix that, since the re-applied value is an equal but
not identical Date and passes Lit's dirty check. So the setter is now
idempotent: an assignment that deep-equals the current value is a no-op and
cannot disturb an edit in progress.

Spinning and Ctrl+; while focused move the draft; unfocused stepUp/stepDown,
clear(), setRangeText() and drops still commit immediately, as they have no
blur coming to commit them. The pickers stop assigning their own value on
igcInput and read the draft instead, so the calendar keeps following along
while the user types.

Same treatment for igc-date-range-input, and the shared logic - commit,
draft, mask display, clear and setRangeText - now lives once in
IgcDateTimeInputBaseComponent, which became generic over its value type.
Both concrete inputs come out smaller than before the fix.

Behavioral change: reading `.value` mid-typing now returns the last committed
value.

Closes #1346

Coverage Stats

6525 of 6855 branches covered (95.19%)

Branch coverage included in aggregate %.

302 of 303 new or added lines in 6 files covered. (99.67%)

1 existing line in 1 file now uncovered.

46565 of 47112 relevant lines covered (98.84%)

1806.31 hits per line