IgniteUI / igniteui-webcomponents / 31142393729

98%

Build Type

push

github

Committed by web-flow

Commit Message

fix(combo): correct selection/filtering bugs and speed up large data sets (#2311)

Selection is now mutated only after the cancellable igcChange event is
accepted, so preventing it no longer wipes the current single selection.
disable-filtering is honored on the main input too, which is the only
filtering path single-select has.

Selection resolution goes through a lazily built value index instead of
scanning the data source per item, and the filter memoizes each record's
normalized text instead of re-normalizing every record on every keystroke:

  - setting 2000 values over 20k records: 208ms -> 4ms
  - 7 keystrokes over 20k accented records: 102ms -> 37ms

aria-posinset/aria-setsize now exclude group headers, and
aria-activedescendant is derived from the active index rather than assigned
mid-render, dropping an extra update cycle per keypress.

Internally: select/deselect collapse into a single path, ComboRecord loses
the redundant dataIndex, and the active-index write path is centralized.

Coverage Stats

6516 of 6851 branches covered (95.11%)

Branch coverage included in aggregate %.

408 of 413 new or added lines in 5 files covered. (98.79%)

16 existing lines in 2 files now uncovered.

46461 of 47010 relevant lines covered (98.83%)

1820.8 hits per line