dangernoodle-io / breadboard / 31140470258

97%

push

github

refactor: collapse bb_data_http_attach/_ex/_sized onto a single cfg entry point (B1-1439) (#1249)

bb_data_http_attach()/bb_data_http_attach_ex()/bb_data_http_attach_sized()
merge into bb_data_http_attach(const bb_data_http_attach_cfg_t *cfg) --
the last conversion in epic B1-1434. cfg->kind zero-defaults to
BB_DATA_HTTP_STATE (the enum's own explicit = 0), matching the old base
attach()'s hardcoded kind exactly. cfg->snap_size zero-defaults to "no
size guard" -- 0 never exceeds CONFIG_BB_DATA_HTTP_RENDER_SCRATCH_BYTES
(Kconfig range 32-2048), matching the old attach()/attach_ex() pair's
complete absence of a snap_size parameter. All 91 call sites convert:
56 base + 29 _ex in test/test_host/test_bb_data_http.c, 4 _sized in the
same test file, and 2 handwired production callers
(examples/floor/main/floor_app.c, examples/smoke/main/smoke_data_notify.c).
The examples/smoke codegen marker (bb_wire.h) splices a compound-literal
cfg the same way the existing bb_data_bind() marker already does --
wire.py's args= emitter needed no code change. Adds a cfg==NULL
invalid-arg test and a kind-zero-default equivalence test (mutation-
verified: forcing the wrong kind fails the new test and 20 others).

Claude-Session: https://claude.ai/code/session_0119nuE2NZME9y2aYEVJTPB5

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

8544 of 9084 branches covered (94.06%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 1 file covered. (100.0%)

14274 of 14429 relevant lines covered (98.93%)

2593.44 hits per line