kobotoolbox / kpi / 31119557255

59%

master: 76%

push

github

fix(formbuilder): crash with unsupported type DEV-2616 (#7392)

### 📣 Summary

Fixed Form Builder failing to open forms that contain question types it
can't edit, and no longer dropping those questions when the form is
saved.

### 📖 Description

Some valid XLSForm question types have no editor in Form Builder.
Opening such a form used to break the editor, and saving it - silently
deleted the question.

Now those questions show up as a card explaining that they can't be
edited here and will be left alone when you save. The rest of the form
works normally. Affected types include `select_one_external`, `email`,
`osm`, `percentage`, `phone number`, `number of days in last month`/`six
months`/`year`, `q select`, `q select1`, and the `uri:*` metadata types.

A card:

<img width="1056" height="315" alt="Screenshot 2026-08-05 at 16 16 51"
src="https://github.com/user-attachments/assets/4080a91f-2a7b-41e7-9d79-61a315b6b547"
/>

### 💭 Notes

Changes here:

- **`model.configs.coffee`** — registered 16 types in `lookupRowType`
with `supportedByUI: false`
- **`model.row.coffee`**
- `processType` now checks the whole type value against the registry
before splitting on spaces. Six of the new types contain spaces, so
`"phone number"` was being read as type `phone` + choice list `number`.
That's why they were never found, and it also stuck a bogus `listName`
on the row.
- `toJSON2` splits `select_one_external` back into `type` +
`select_from_list_name`, since the constructor merges them. Unlike
`select_one` it can legitimately have no list name, so we don't invent
an empty one.
- **`view.row.coffee`**
- `_renderRow` branches on the new `hiddenInUI` flag:
`background-geopoint` stays invisible as before, everything else gets
the notice card.
- `applyLocking` bails when there's no `@$card` (both implementations).
Error rows render no card, and `RowView.initialize` binds this to every
survey `change` event, so it was guaranteed to throw.
- **`view.row.templates.coffee` / ... (continued)

6065 of 12733 branches covered (47.63%)

22368 of 37625 relevant lines covered (59.45%)

1.02 hits per line