Kikobeats / cacheable-response / 31116801903

99%

push

github

fix: make cache bypass actually refresh and stay uncached (#142)

* fix: make cache bypass actually refresh and stay uncached

Two bypass paths advertised the wrong HTTP caching behavior:

1. Custom keys that pass query-string force values (e.g. req.query.force
   === 'true') never refreshed because @keyvhq/memoize only treats
   forceExpiration === true as expired. Headers said BYPASS while the
   stale body was still served. Coerce the flag to boolean before memoize.

2. Returning null/undefined from .get() is documented as preventing
   caching, but responses still sent public max-age Cache-Control, so
   CDNs could store fallback/error bodies. Send no-store when memoize
   produced no payload.

Co-authored-by: kikohumanbeatbox <kikohumanbeatbox@gmail.com>

* refactor: tighten the memoize key normalization

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MTbj6CYXGsk6rhXx7J8SUP

* test: cover falsy force value in custom key

Boolean() coercion keeps custom keys aligned with the default
presence-based bypassQueryParameter semantics.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QpdsjFkcyG4NHixpoVwWKq

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: kikohumanbeatbox <kikohumanbeatbox@gmail.com>
Co-authored-by: Kiko Beats <josefrancisco.verdu@gmail.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

59 of 63 branches covered (93.65%)

Branch coverage included in aggregate %.

15 of 15 new or added lines in 2 files covered. (100.0%)

213 of 213 relevant lines covered (100.0%)

34.06 hits per line