FlexMeasures / flexmeasures / 31108627085

84%

push

github

fix icon mapping for asset types one-way_evse and two-way_evse, and add other names, as well (#2391)

* fix icon mapping for asset types one-way_evse and two-way_evse

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* PR number in changelog

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* ui: show icons for more asset types in the asset structure view

The structure view fell back to a question mark for any asset type
missing from SVG_ICON_MAPPING. Three of the eight asset types that
FlexMeasures seeds by default were missing (wind, process and
heat-storage), as was EV infrastructure under names other than the two
canonical EVSE ones.

Add those three, and map the EV names that projects commonly use.
Introduce a CHARGER_ICON constant, since the charger URL is now shared
by several entries, and a FALLBACK_SVG_ICON constant for the question
mark, so tests can assert against it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* ui: match asset type names ignoring case and separators

Asset type names are not restricted, so projects spell the same type in
their own way. The Campus project, for instance, types its chargers as
'charge-point' and 'charging-station', which found no icon even though
SVG_ICON_MAPPING already had a 'chargepoint' entry.

Look up icons by a normalized name, keeping only lower-case
alphanumeric characters, so that separator and case variants share one
entry. The dot-separated split is kept and applied first, so a plugin's
namespaced type (for example 'myplugin.battery') still matches on its
last component.

A test guards against two mapping keys normalizing to the same name,
which would silently shadow each other.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* ui: show icons for building services equipment

The Campus project types most of its assets as building services
equipment (hvac, ahu, dhw, heatpump, chiller, lighting and
other-loads), which had no icon and so filled its asset structure view
with que... (continued)

7 of 7 new or added lines in 1 file covered. (100.0%)

17178 of 20459 relevant lines covered (83.96%)

0.84 hits per line