chideat / valkey-operator / 31065989368

24%

Build Type

push

github

Committed by web-flow

Commit Message

fix: controller fixes (slot guard, Pending-recovery, NodePort webhook, User phase key) (#101)

* fix(cluster): don't reassign slots a disconnected-but-intact shard owns

The engine judged shard master/slot presence via the IsJoined-gated accessors
shard.Master()/shard.Slots(), which return nil/empty when a node can't currently
see a peer. After a full restart a master that still locally owns its slots but
can't reach its peers was therefore treated as masterless/slotless, triggering
destructive EnsureSlots/Rebalance (ADDSLOTS, FAILOVER, SETSLOT) that created
epoch/slot conflicts and prevented reconvergence (risking split-brain).

Add ungated predicates (ShardAssignedSlots, ShardHasMaster, IsDisconnectedButIntact)
in internal/ops/cluster/predicate.go that judge ownership from the master node's
real local slots regardless of peer connectivity, and base the reassignment
decision on actual ownership: a disconnected-but-intact shard waits to re-MEET
instead of reassigning slots it already holds. Gated in engine check_4 and the
ensure_slots / join_node / rebalance actors.

Ported from redis-operator 7e6f6910 (RedisRole->NodeRole, type name adaptation).

* fix(cluster,failover): recover a Pending instance after a resource downscale

An instance created with oversized resources (all pods Pending) never recovered
after patching spec.resources down: with Pending pods the engine loops in
HealPod / HealMonitor and never reaches EnsureResource (the only actor that
updates the StatefulSet), so the desired resources never reach the template and
the pods stay Pending forever.

- cluster HealPod: always fall through to CommandEnsureResource, and delete
  stale-revision Pending pods so the StatefulSet recreates them from the updated
  template. valkey's cluster StatefulSet uses ParallelPodManagement + RollingUpdate,
  so the comment reflects that (not redis's OrderedReady premise).
- failover HealMonitor: return CommandEnsureResource instead of idle-waiting when
  no u... (continued)

Coverage Stats

90 of 154 new or added lines in 10 files covered. (58.44%)

48 existing lines in 3 files now uncovered.

4965 of 20677 relevant lines covered (24.01%)

0.28 hits per line