chideat / valkey-operator / 29337488663

24%

Build Type

push

github

Committed by web-flow

Commit Message

fix: cluster arch on ClusterIP access, and stranded password secret finalizer (#99)

* fix: create pod binded services for cluster arch on ClusterIP access

ensureService switches on Access.ServiceType with cases for NodePort and
LoadBalancer only. ServiceType is a closed enum defaulted to ClusterIP, so the
default path matches no case and ensureValkeyPodService never runs. The per-pod
service is therefore never created, and init_cluster.sh's `valkey-helper cluster
expose` -- which requires a service named after the pod to resolve its announce
address -- exits 1, leaving every node in Init:CrashLoopBackOff.

The effect is that cluster arch only ever comes up when access.serviceType is
NodePort or LoadBalancer. The default, in-cluster ClusterIP mode never starts.

Failover already handles this correctly: its ensureService sends everything
except NodePort-with-ports to ensureValkeyPodService, which is why
failover+ClusterIP works. This aligns cluster with that behaviour.

cleanUselessService's LoadBalancer/NodePort guard is dropped for the same
reason: all three service types now have pod binded services, so scale-down must
reclaim them for ClusterIP too. fetchAllPodBindedServices already filters to
services carrying a pod-name selector, so headless and instance services are
unaffected. Failover's equivalent has no such guard either.

Verified on a live cluster: a 3-shard ClusterIP cluster crash-looped in init;
with this change the same spec reaches Ready with cluster_state:ok, 16384 slots
assigned, and each node announcing its pod IP -- which is what Access() intends
for the non-NodePort path, where announceIp is pod.Status.PodIP.

The e2e suite does not catch this: all three arch suites in e2e_test.go are
commented "with ClusterIP service type" but construct their parameters with
corev1.ServiceTypeNodePort, so only the working path is ever exercised.

* fix: only finalize the password secret once the user exists

The secret finalizer is added while re... (continued)

Coverage Stats

0 of 22 new or added lines in 2 files covered. (0.0%)

167 existing lines in 7 files now uncovered.

4610 of 20595 relevant lines covered (22.38%)

0.26 hits per line