decentraland / comms-gatekeeper / 31058160053

86%

main: 86%

Build Type

Pull #284

github

Committed by LautaroPetaccio

Commit Message

fix: evaluate the request device id on the stream-key gates

the gates added in 635ccdc passed only the address, so a wallet with no ban and no
recorded connection could reuse or mint a streaming key while the request itself
carried a device id covered by an active ban. the key is later honoured by
validateStreamerToken without a wallet re-check, so these routes should evaluate
the same device term the connection gate does.

validate(ctx) already returns deviceIdentifier in both handlers, so this is one
field on the destructure and one on the call — no component signature changes. the
ban check moves after validate() to get it, which in the reset handler keeps it
outside the try that maps non-UnauthorizedError to a 500.

no client sends a device id here today: both routes are scene-signed, and the
explorer's SignatureMetadata has no field for one. the term is evaluated when
present rather than left on the floor.

tests cover a clean wallet with no recorded connection presenting a banned device
on both reuse and reset, asserting no key is returned and none is minted. verified
they fail without the device term.

Pull Request Pull Request #284: feat: enforce platform bans on voice and cast, and make ban status match the gate

Coverage Stats

1143 of 1457 branches covered (78.45%)

Branch coverage included in aggregate %.

44 of 45 new or added lines in 9 files covered. (97.78%)

2 existing lines in 1 file now uncovered.

3123 of 3523 relevant lines covered (88.65%)

77.31 hits per line