decentraland / comms-gatekeeper / 31057257646

86%

main: 86%

Build Type

Pull #284

github

Committed by LautaroPetaccio

Commit Message

fix: gate the legacy scene-stream-access endpoints on platform bans

POST and PUT /scene-stream-access are wallet-scoped signed-fetch admin endpoints
that return or mint a streaming_key, and neither consulted userModeration. a
platform-banned scene admin could take a key from either and exchange it through
validateStreamerToken or generatePresentationBotToken, which trust a minted key
without re-checking the wallet. that is the same hole the local-preview fix closed,
on the routes the cast work did not touch — so 'blocking the mint covers streaming'
was only true of the cast route.

gate both before the admin lookup, matching generateStreamLink, so a banned wallet
gets the same answer whether or not it is an admin.

the reset handler raises outside its try block on purpose: that block maps anything
but UnauthorizedError to a 500, so a ForbiddenError thrown inside would have
surfaced as a server error rather than a rejection. a test pins the 403.

covers the recorded-device match too, since both go through
getActiveBanForConnection: an admin with no ban of their own is refused when the
device they last connected from is banned.

Pull Request Pull Request #284: feat: enforce platform bans on voice and cast, and make ban status match the gate

Coverage Stats

1143 of 1457 branches covered (78.45%)

Branch coverage included in aggregate %.

44 of 45 new or added lines in 9 files covered. (97.78%)

9 existing lines in 3 files now uncovered.

3123 of 3523 relevant lines covered (88.65%)

77.18 hits per line