twbs / bootstrap / 31041839117

94%

main: 96%

push

github

Return a promise from the JavaScript lifecycle methods (#42802)

* Remove the Collapse toggle option

The `toggle` option made the constructor change the state that the markup
declares. That surprised people, so almost every caller passed
`toggle: false`. Remove the option and always keep the declared state.
Call `show()`, `hide()`, or `toggle()` to change it.

* Return a promise from the JavaScript lifecycle methods

`show()`, `hide()`, `toggle()`, and `close()` returned before the
transition ended, so a caller had to listen for a `shown.bs.*` or
`hidden.bs.*` event to continue. `_queueCallback` now returns a promise
and each component awaits it, so a caller can `await` the method instead.
The promise always settles, so a no-op call cannot strand the caller.

1745 of 1961 branches covered (88.99%)

Branch coverage included in aggregate %.

39 of 39 new or added lines in 8 files covered. (100.0%)

3596 of 3726 relevant lines covered (96.51%)

112.69 hits per line