decentraland / comms-gatekeeper / 31030859631

86%

main: 85%

Build Type

Pull #284

github

Committed by LautaroPetaccio

Commit Message

fix: gate local-preview stream links and harden best-effort error reporting

addresses two review findings.

local-preview stream-link minting bypassed the platform-ban gate. the handler
branches to generatePreviewStreamLink when livekit.isLocalPreview(realmName) is
true, and the assertion only lived in generateStreamLink. that branch also skips
the admin check, and the realm name deciding it comes from self-asserted auth
metadata, so wherever ALLOW_LOCAL_PREVIEW is on a banned wallet could mint a
working streaming key in one request — and validateStreamerToken honours a minted
key without re-checking the wallet, so the "blocking the mint covers streaming"
model had a hole straight through it.

gate the preview path too, at the top, before the synthetic place is built. left
the assertion at each of the two call sites rather than moving it into the shared
createStreamAccess helper: generateStreamLink must check before its admin lookup
so the rejection cannot double as an admin-status oracle, and a check inside the
helper would run after it. noted at createStreamAccess that every caller has to
gate first, since the key it mints is trusted downstream.

this matches comms-scene-handler, which applies the platform ban before it
branches on preview and only skips the scene-ban check for it.

the recorded-device catch read error.message directly, so a rejection that is not
an object took down the very gate the catch exists to keep non-fatal. only null
and undefined actually threw — a string or number yields undefined and logs
"undefined" — but the failure is real and the path is documented as fail-open.
route the message through the existing isErrorWithMessage helper.

widened to the other three catches in the file rather than fixing one of four
identical latent bugs: two are fire-and-forget, where a throw becomes an
unhandled rejection, and the third would fail banPlayer outright over a
best-effort connection-info read.

tests cover a banned local-preview c... (continued)

Pull Request Pull Request #284: feat: enforce platform bans on voice and cast, and fall back to the recorded device

Coverage Stats

1134 of 1448 branches covered (78.31%)

Branch coverage included in aggregate %.

30 of 30 new or added lines in 5 files covered. (100.0%)

3 existing lines in 1 file now uncovered.

3111 of 3511 relevant lines covered (88.61%)

76.81 hits per line