adaptive-machine-learning / CapyMOA / 31006143951

80%

Build Type

push

github

Committed by hmgomes

Commit Message

fix(drift): make random_seed keyword-only so leftover alpha fails loudly

Raised in review. Removing `alpha` left a hazard for the positional form:
`Drift(1000, 500, 0.1)` bound 0.1 to `random_seed` instead of raising, and
the mistake only surfaced later inside MOA as

    NumberFormatException: For input string: "0.1"

`GradualDrift(1000, 500, None, None, 0.1)` did the same. The PR text
claimed passing `alpha` raises TypeError, which was only true of the
keyword form.

`random_seed` is now keyword-only on both classes, so a leftover argument
fails at the call site. Nothing passes it positionally: the only
positional use anywhere is the first argument, and recurrent streams
rebuild drifts with `drift_cls(**drift_args)`.

AbruptDrift is unchanged -- it never had `alpha`, so its second positional
argument has always been the seed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Coverage Stats

12 of 12 new or added lines in 2 files covered. (100.0%)

8 existing lines in 1 file now uncovered.

7899 of 10206 relevant lines covered (77.4%)

0.77 hits per line