iotaledger / iota / 30966684274

70%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(node): Remove RocksDB snapshot tooling (#12386)

# ❗Do not merge before #12332 

# Description of change

With verifiable formal snapshots available, RocksDB snapshots are no
longer needed as a restore mechanism. This removes the RocksDB snapshot
tooling:

- Remove `DBCheckpointConfig` (`db-checkpoint-config`) from the node
config. The epoch-end RocksDB checkpoint is still taken, but only as
internal input for formal snapshot creation, gated directly on
`state-snapshot-write-config`.
- Delete `DBCheckpointHandler` (upload/manifest/GC loops and marker-file
coordination). The state snapshot uploader now deletes the local db
checkpoint directory once the formal snapshot for that epoch is uploaded
or skipped.
- Remove the `iota-tool` `download-db-snapshot` and `restore-db`
commands.
- Remove related e2e test.


## Links to any relevant issues

fixes #12326

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] Patch-specific tests (correctness, functionality coverage)
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have checked that new and existing unit tests pass locally with
my changes


### Release Notes

- [ ] Protocol:
- [x] Nodes (Validators and Full nodes): The `db-checkpoint-config` node
config section is removed; nodes no longer generate or upload RocksDB
snapshots, and the `first_missing_db_checkpoint_epoch` and
`num_local_db_checkpoints` metrics are removed.
- [ ] Indexer:
- [ ] JSON-RPC:
- [ ] GraphQL:
- [x] CLI: The `iota-tool download-db-snapshot` and `iota-tool
restore-db` commands are removed; use `iota-tool
download-formal-snapshot` to restore a node.
- [ ] Rust SDK:
- [ ] gRPC:

#### Breaking Changes Rollout

Affected Crates:

- iota-config
- iota-node
- iota-tool

Required User Actions:

- Operators publishing RocksDB snapshots can remove the
`db-checkpoint-config` section from their node config; it no longer has
any effect... (continued)

Coverage Stats

16 of 21 new or added lines in 4 files covered. (76.19%)

175 existing lines in 23 files now uncovered.

165740 of 239290 relevant lines covered (69.26%)

475375.8 hits per line