source-academy / frontend / 30958011680

45%

Build Type

push

github

Committed by web-flow

Commit Message

Correct off-by-one prepend line shift in Conductor error messages (#4244) (#4245)

evalEditorSaga concatenates `${prepend}\n${entrypoint}` before sending it
to the evaluator under Conductor, so a reported error's line number was
relative to that combined text - a one-line PREPEND made every error line
off-by-one. Subtract the same prepend-line offset already applied to
breakpointLines, using the evaluator's structured line/column/rawMessage
fields (duck-typed, since a Worker's postMessage clone drops the original
EvaluatorError prototype) instead of its pre-baked message string. The
offset is tracked per-session via a mutable ref so it resets to 0 for a
later REPL chunk sent to an already-live session, which has no prepend
concatenated onto it.


Claude-Session: https://claude.ai/code/session_01HZ2e6QFxwCn1rkTjdhKCSS

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

Coverage Stats

3064 of 7800 branches covered (39.28%)

Branch coverage included in aggregate %.

12 of 14 new or added lines in 1 file covered. (85.71%)

3 existing lines in 1 file now uncovered.

7028 of 14541 relevant lines covered (48.33%)

30.3 hits per line