microlinkhq / browserless / 30949979540

81%

push

github

fix: context leaks, screenshot readiness, and prepare scroll (#869)

* fix(screenshot): hydrate white overflow viewports during readiness

tryHydrateScroll was gated on !isWhite, but the default isPageReady is
!isWhite — so a white viewport made the hydrate condition unreachable.
Overflow/lazy SPAs that stay blank until scrolled never got the one-shot
hydrate from #852, and fullPage/PDF then skipped prepareFullDocument and
returned a blank capture as success.

Drop the !isWhite guard so the budgeted hydrate can run when the viewport
is still white.

Co-authored-by: kikohumanbeatbox <kikohumanbeatbox@gmail.com>

* fix(screenshot): drop probe quality; tolerate prepare scroll nav

#852's fullPage readiness probe clears `path` so it does not write during
the white check. #858 keeps `quality` when that path looked lossy. Together
the probe becomes `{ quality }` on puppeteer's png default and throws
`png screenshots do not support 'quality'`. Drop quality with the path on
the probe; the final fullPage capture still receives both.

Also wrap prepareFullDocument's scroll in pReflect like its overflow wait
and expand siblings. A SPA that client-navigates during the multi-second
scroll was failing the whole PDF/fullPage job with a bare context-destroyed
throw from settleDom/evaluate.

Co-authored-by: kikohumanbeatbox <kikohumanbeatbox@gmail.com>

* fix(function): destroy browser context after each page invocation

runWithBrowser created an isolated BrowserContext per call but only
closed the page via withPage, so repeated @browserless/function runs
that reference page accumulated orphaned Chromium contexts until the
process exhausted memory. Tear the context down in a finally block,
including when withPage rejects.

Co-authored-by: kikohumanbeatbox <kikohumanbeatbox@gmail.com>

* test(function): assert context teardown after withPage failure

Lock in that destroyContext still runs when the page path rejects, so
orphaned BrowserContexts cannot accumulate on the ... (continued)

725 of 886 branches covered (81.83%)

Branch coverage included in aggregate %.

44 of 47 new or added lines in 4 files covered. (93.62%)

3836 of 4774 relevant lines covered (80.35%)

104958.52 hits per line