archetech / archon / 30939381859

95%

push

github

fix(keymaster): narrow chrome.storage value instead of trusting its type (#860)

@types/chrome 0.2.x types chrome.storage.local.get() as returning `unknown`
rather than `any`, so passing the value straight to JSON.parse no longer
compiles:

  src/db/chrome.ts(28,31): error TS2345: Argument of type 'unknown' is not
  assignable to parameter of type 'string'.

The new typing is the honest one. Extension storage is shared with the rest of
the extension, so nothing guarantees the value is the JSON string saveWallet()
wrote — the old `any` was hiding an unchecked assumption rather than expressing
a fact. Narrows on `typeof stored === 'string'` and treats anything else as an
absent wallet, rather than asserting the type away.

This blocks the pending @types/chrome ^0.1.38 -> ^0.2.5 bump: the single error
fails `build:esm` for @didcid/keymaster, which cascades into every image build,
the explorer, extension and android builds, and the gatekeeper parity job.

Verified against both typings: the package typechecks clean under the current
0.0.309 and under 0.2.5, and reverting this change under 0.2.5 reproduces CI's
exact error.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

3609 of 4063 branches covered (88.83%)

Branch coverage included in aggregate %.

8230 of 8512 relevant lines covered (96.69%)

687.14 hits per line