nasa / cml / 30930305962

90%

push

github

Create initial clang-tidy action (#71)

Set up the basic clang-tidy checks and added them to the CI pipeline.
There's several sibling issues for adding the additional checks like
bugprone-*, modernize-*, etc. that will happen in separate pull
requests.

Changes to address clang-tidy warnings:
- Converted the std_atmos_1976 model's layer_number variable from a
  signed to an unsigned integer. clang-tidy identified a path where
  that value could theoretically be negative and we'd therefore access
  data outside of an array bounds.
- General updates in std_atmos_1976: use std::size(thing) rather than
  sizeof(thing) / sizeof(thing[0]).
- Added a guard that ensures value is not nullptr for the case of a
  Trigger<std::string>::set_value, since that would attempt to construct
  a string from a null char*. Making this a no-op mimics what's being
  done for non-std::string trigger types in FaultManager::make_trigger,
  where we only set the value if the input value is not null. 
- Updated some quaternion copies from using lhs.copy_from(rhs) to
  lhs = rhs. That copy_from function expects a double[4] as input, 
  which JEOD quaternions are technically convertible to, but that
  conversion to an array passes the address of the quaternion scalar
  element and relies on the fact that the vector portion is adjacent in
  memory. clang-tidy flags that as an out-of-bounds read of the scalar
  element.

Refs #49

7825 of 8509 branches covered (91.96%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 3 files covered. (100.0%)

17867 of 19970 relevant lines covered (89.47%)

115998.94 hits per line